[librt.strings] Make various methods only accept positional args #20589
+29
−29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
p-sawicki
approved these changes
Jan 15, 2026
Collaborator
Author
|
The parallel test failure is most likely a flake. cc @ilevkivskyi |
michaelm-openai
pushed a commit
to michaelm-openai/mypy
that referenced
this pull request
Jan 16, 2026
…hon#20589) This makes non-native calls a little faster.
michaelm-openai
pushed a commit
to michaelm-openai/mypy
that referenced
this pull request
Jan 16, 2026
…hon#20589) This makes non-native calls a little faster.
Member
|
Interesting, I see the problem is that We can possibly increase the timeout from 3 sec to say 5 sec during tests. But first maybe it would make sense to add some more logging, e.g. show what was the last exception that caused this, just to get a better idea of what is going on. |
Member
|
Added in #20599 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes non-native calls a little faster.